Add a discovery implementation in Python.#1
Merged
kofi-clever merged 3 commits intomasterfrom Mar 14, 2016
Merged
Conversation
kofi-clever
force-pushed
the
discover-things
branch
3 times, most recently
from
7c714c5 to
a57a3f7
Compare
Contributor
Author
|
ping - lmk if you've got time to take a look at this |
kofi-clever
force-pushed
the
discover-things
branch
5 times, most recently
from
90d72ca to
5832709
Compare
Contributor
Author
|
@dfuentes - got time to take a look today? |
Contributor
|
Was on vacation most of last week, I can take a look today |
Contributor
Author
|
ah sorry, missed that on the cal. thanks! |
Contributor
There was a problem hiding this comment.
{PROTOCOL} is not part of the env var name. The proper name for this field is {EXPOSE}
Contributor
Author
There was a problem hiding this comment.
good to know - fixed all other occurrences.
out of curiousity - what does EXPOSE mean in this context?
Contributor
There was a problem hiding this comment.
It's the name of the expose block, for example for this launch yaml (https://github.com/Clever/appasaurus/blob/master/launch/appasaurus.yml#L18) it would be thrift
kofi-clever
force-pushed
the
discover-things
branch
from
5832709 to
11b7c96
Compare
Contributor
|
lgtm |
kofi-clever
added a commit
that referenced
this pull request
Mar 14, 2016
Add a discovery implementation in Python.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.